Add NotFound when submodel not found within AAS #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…min-shell-io/aasx-server into jtikekar/BugFixes/test-engine
…min-shell-io/aasx-server into jtikekar/BugFixes/test-engine
AlexanderWollbrink
pushed a commit
that referenced
this pull request
Sep 2, 2024
* Fix bugs w.r.t. test-engine * Fix for GH issue 333 * Fix for GH issue 333 * Add NotFound exception when submodel not found withing AAS
aorzelskiGH
pushed a commit
that referenced
this pull request
Sep 4, 2024
* Add NotFound when submodel not found within AAS (#337) * Fix bugs w.r.t. test-engine * Fix for GH issue 333 * Fix for GH issue 333 * Add NotFound exception when submodel not found withing AAS * Fix bugs w.r.t. test-engine * Fix serialization of ServiceProfiles (#338) * Add constructor to ServiceDescription API (#341) * fix for Dockerfile platforms not working correctly * TimeStampDelete start * TimeStampDelete change * TimeStampDelete change * Bug fix * Bug fix --------- Co-authored-by: juileetikekar <[email protected]> Co-authored-by: juileetikekar <[email protected]> Co-authored-by: Alexander Wollbrink <[email protected]>
aorzelskiGH
pushed a commit
that referenced
this pull request
Oct 9, 2024
* Add NotFound when submodel not found within AAS (#337) * Fix bugs w.r.t. test-engine * Fix for GH issue 333 * Fix for GH issue 333 * Add NotFound exception when submodel not found withing AAS * Fix bugs w.r.t. test-engine * Fix serialization of ServiceProfiles (#338) * Add constructor to ServiceDescription API (#341) * fix for Dockerfile platforms not working correctly * TimeStampDelete start * TimeStampDelete change * TimeStampDelete change * Bug fix * Bug fix --------- Co-authored-by: juileetikekar <[email protected]> Co-authored-by: juileetikekar <[email protected]> Co-authored-by: Alexander Wollbrink <[email protected]>
aorzelskiGH
pushed a commit
that referenced
this pull request
Nov 8, 2024
* Add NotFound when submodel not found within AAS (#337) * Fix bugs w.r.t. test-engine * Fix for GH issue 333 * Fix for GH issue 333 * Add NotFound exception when submodel not found withing AAS * Fix bugs w.r.t. test-engine * Fix serialization of ServiceProfiles (#338) * Add constructor to ServiceDescription API (#341) * fix for Dockerfile platforms not working correctly * TimeStampDelete start * TimeStampDelete change * TimeStampDelete change * Bug fix * Bug fix --------- Co-authored-by: juileetikekar <[email protected]> Co-authored-by: juileetikekar <[email protected]> Co-authored-by: Alexander Wollbrink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consists of a bug-fix for the error message when a submodel from the request is not present in the requested AAS.
Motivation and Context
Earlier implementation used to throw 500 (internal server error), when the requested submodel (with the submodelId) is not present within the requested AAS. With this PR it throws NotFound.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The fixes are tested manually with the help of in-buit swagger-ui and with aas-test-engine.
Screenshots (if appropriate):
Checklist: